-
Notifications
You must be signed in to change notification settings - Fork 82
MNT/TST: add pyside6 testing runs to gh-actions automation #1286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT/TST: add pyside6 testing runs to gh-actions automation #1286
Conversation
for now just disable the few failing tests. and making a separate yaml file for pyside6 setup/running to avoid complicating the pyqt5 yaml file any more.
0560784
to
cdcd6f2
Compare
a06b38e
to
4992bdd
Compare
4992bdd
to
1eeb211
Compare
1eeb211
to
3513e9e
Compare
the tests fail in gh-actions also b/c of the odd errors we get only when running pyside6 with pytest. for now use pyside6 automated runs as a reference but not as blocking for merge
b75fdc1
to
25253b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Since the file is renamed, will need to update the line here to keep the status badge working:
Line 1 in 9ff9dbf
[](https://github.com/slaclab/pydm/actions/workflows/run-tests.yml) |
fixed now |
for now just pass pyside6 tests regardless, use the result as reference on pyside6 status and not blocking for merge.
made a separate yaml file for pyside6 setup/running to avoid
complicating the pyqt5 yaml file any more.