Skip to content

Conversation

nstelter-slac
Copy link
Collaborator

@nstelter-slac nstelter-slac commented Sep 8, 2025

for now just pass pyside6 tests regardless, use the result as reference on pyside6 status and not blocking for merge.

made a separate yaml file for pyside6 setup/running to avoid
complicating the pyqt5 yaml file any more.

for now just disable the few failing tests.
and making a separate yaml file for pyside6 setup/running to avoid
complicating the pyqt5 yaml file any more.
@nstelter-slac nstelter-slac linked an issue Sep 8, 2025 that may be closed by this pull request
@nstelter-slac nstelter-slac force-pushed the pyside6_in_automation branch 3 times, most recently from a06b38e to 4992bdd Compare September 17, 2025 21:59
@nstelter-slac nstelter-slac marked this pull request as ready for review September 17, 2025 22:01
@nstelter-slac nstelter-slac marked this pull request as draft September 17, 2025 22:02
@nstelter-slac nstelter-slac marked this pull request as ready for review September 17, 2025 22:20
the tests fail in gh-actions also b/c of the odd errors we get only
when running pyside6 with pytest.

for now use pyside6 automated runs as a reference but not as blocking
for merge
Copy link
Collaborator

@jbellister-slac jbellister-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Since the file is renamed, will need to update the line here to keep the status badge working:

[![Build Status](https://github.com/slaclab/pydm/actions/workflows/run-tests.yml/badge.svg?branch=master)](https://github.com/slaclab/pydm/actions/workflows/run-tests.yml)

@nstelter-slac
Copy link
Collaborator Author

Looks good. Since the file is renamed, will need to update the line here to keep the status badge working:

[![Build Status](https://github.com/slaclab/pydm/actions/workflows/run-tests.yml/badge.svg?branch=master)](https://github.com/slaclab/pydm/actions/workflows/run-tests.yml)

fixed now

@jbellister-slac jbellister-slac merged commit 2e0a4b6 into slaclab:master Oct 4, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pyside6 runs to github automated testing

3 participants