-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This pull request introduces some changes to the SRF Auto Plot functionality: #22
base: main
Are you sure you want to change the base?
Conversation
@hmarts9 have you had a chance to look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! If this is just a problem with my local version that's fine but it wasn't scrolling until I added the update mode line. If it works for you I'll switch this to approved
self.verticalLayout.addLayout(self.horizontalLayout_2) | ||
|
||
# Plot | ||
self.plot = PyDMArchiverTimePlot() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be in the init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely understand wanting to move it in the init, but I just put it in the setup_ui method, bc it follows separation of concerns principle by grouping all UI creation into one dedicated method. I can move it if you think thats better though.
# Plot | ||
self.plot = PyDMArchiverTimePlot() | ||
self.plot.setTimeSpan(600) | ||
self.plot.setUpdatesAsynchronously(True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the line self.plot.updateMode = PyDMTimePlot.AtFixedRated
to actually make it scroll, at least in my local testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah youre right. That would help with the scrolling behavior ill add it!
Changes
Key Updates