fix: Analyze with AST for translation detection#328
fix: Analyze with AST for translation detection#328thanhson13 wants to merge 1 commit intoslang-i18n:mainfrom
Conversation
|
|
||
| TranslationUsageAnalyzer({required this.translateVar}); | ||
|
|
||
| Set<String> analyzeFile(String filePath) { |
There was a problem hiding this comment.
Please use String as an input so we can avoid file I/O in unit tests.
You can keep analyzeFile as a wrapper function for analyzeString / analyzeCode.
| sdk: ">=3.3.0 <4.0.0" | ||
|
|
||
| dependencies: | ||
| analyzer: '>=6.0.0' |
There was a problem hiding this comment.
I believe this will be biggest pain point. The slang package contains both the runtime and CLI tools.
Adding analyzer will introduce lots of transitive dependencies that should be only dev_dependencies.
|
Overall, thank you for your contribution. |
|
Got it. I'll do some research on the |
Tienisto
force-pushed
the
main
branch
3 times, most recently
from
8cf55b9 to
7e67166
Compare
2 participants
fix #310