(feat) members cannot see training deactivated in the list

sleede · Dec 12, 2024 · 362cdc4 · 362cdc4
1 parent adeb3ac
commit 362cdc4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ## Next release
 
 - Improvement: default order for the spaces/trainings list is set to descending by created_at
+- Improvement: members cannot see training deactivated in the list
 
 ## v6.3.35 2024 November 13
 

diff --git a/app/controllers/api/trainings_controller.rb b/app/controllers/api/trainings_controller.rb
@@ -14,6 +14,7 @@ def index
 
   def show
     @training = Training.friendly.find(params[:id])
+    authorize @training
   end
 
   def create

diff --git a/app/policies/training_policy.rb b/app/policies/training_policy.rb
@@ -8,6 +8,10 @@ def resolve
     end
   end
 
+  def show?
+    !record.disabled? || user.admin? || user.manager?
+  end
+
   def create?
     user.admin?
   end