-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Support gltf #5
base: main
Are you sure you want to change the base?
Conversation
wait, I was not meant to make a PR on 😩 |
src/jockey/geometry.rs
Outdated
Some(vao) => { | ||
unsafe { | ||
gl::DeleteVertexArrays(1, &vao); | ||
// gl_debug_check!(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this leaves me an INVALID_OPERATION
error on exit.
It's weird that it sometimes fails to get uniform location of textures...... sh4der-jockey/src/util/mesh.rs Line 26 in c64b388
|
Anything from |
Description
Points need review
Geometry
/GeometryAttribute
are having vbo / vao as a member. I'm not sure this is a good design decision...gltf
that can be specified directly to vs / vs+fs type stages and I don't think this is a good decisionlocation=0
for now. we have several options about this part:in vec3 position
#define ATTR_INDEX_POSITION 0
for forward compatibilitymaterial_alpha_cutoff
andmaterial_base_color
for nowALPHA_MODE_MASK
(naming is also an issue)model_matrix
based on world space model matrix comes with gltf node graph...I realized this PR involves a lot of major design decisions 😩
You can take it a single sample of project exploration and just discard the PR 😅 ,
I already have enjoyed my rare opportunity reading and writing Rust code