fix: Use globalThis to prevent environment check code from being re…#44
Merged
Merged
Conversation
…moved during bundling with Rolldown
There was a problem hiding this comment.
Pull request overview
Fixes incorrect tree-shaking/minification by some bundlers (Rolldown/tsdown) that were removing runtime RegExp feature-detection logic, which could cause envFlags to be incorrectly constant-folded.
Changes:
- Switched RegExp feature checks to use
globalThis.RegExpto avoid bundler removal/constant-folding. - Added an inline note explaining the bundler-related rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #42
When bundling with Rolldown or tsdown, enabling code minification (compression) or tree-shaking (pruning) will cause the environment check code to be removed.
Before bundling
After bundling
Replacing
RegExpwithglobalThis.RegExpcan prevent this behavior.