Disable breaks while sharing screen#802
Draft
archisman-panigrahi wants to merge 11 commits intoslgobinath:masterfrom
Draft
Disable breaks while sharing screen#802archisman-panigrahi wants to merge 11 commits intoslgobinath:masterfrom
archisman-panigrahi wants to merge 11 commits intoslgobinath:masterfrom
Conversation
also updated dependencies on readme
This reverts commit 19c2253.
archisman-panigrahi
changed the title
Collaborator
Author
|
@hartwork |
Collaborator
Author
|
Turns out safeeyes already did not show any breaks while screen sharing in KDE 5.27. That is probably thanks to #727. I will check how my PR works in other environments |
deltragon
reviewed
Oct 10, 2025
Collaborator
deltragon
left a comment
deltragon
left a comment
There was a problem hiding this comment.
I do like this approach a lot.
It has some downsides: It only works with pipewire, I don't think pulseaudio has an equivalent to this. It also does not work within Flatpaks.
I think we should caution these issues, that this plugin may not work on all desktops/distributions/environments. But I do think this is a good stop-gap, and props for coming up with the pipewire hack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry, not ready yet
This PR would fix #644. Here I am using pipewire to check if some app is sharing screen. I verified in Kubuntu 24.04 (KDE 5.27+Wayland) that when I share screen in Google Meet (Firefox), SafeEyes doesn't show breaks.
I am not completely sure if the dependency checker is working properly (this is the first time I am writing a SafeEyes plugin). Any feedback is welcome. Some people may want to not use piprewire and use pulseaudio instead, and we cannot support them, but we should not force them to install pipewire. So, pipewire should be an optional dependency.
Disclaimer: The code was co-authored with copilot.