fix(client): declare markdown-it-github-alerts as a dependency - #2719
Open
exKAZUu wants to merge 1 commit into
Open
fix(client): declare markdown-it-github-alerts as a dependency#2719exKAZUu wants to merge 1 commit into
exKAZUu wants to merge 1 commit into
Conversation
✅ Deploy Preview for slidev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
packages/client/styles/index.tsimports the stylesheets ofmarkdown-it-github-alerts(since #2547):but
@slidev/clientonly gets the package through hoisting: it is declared inpackages/slidev/package.json, not inpackages/client/package.json. With a package manager layout that does not hoist transitive dependencies next to@slidev/client(e.g. Bun's isolated linker with its global store, where each package can only see its declared dependencies),slidev buildfails with:This PR declares
markdown-it-github-alertsin@slidev/clientvia the existingcatalog:prodentry, so the import resolves regardless of hoisting.pnpm verifypasses locally.Linked Issues
Related to #2547 (which introduced the import).
Additional context
Reproduced with
@slidev/cli@52.19.0installed by Bun 1.4.0 withlinker = "isolated"andglobalStore = true.