Skip to content

fix(client): declare markdown-it-github-alerts as a dependency - #2719

Open
exKAZUu wants to merge 1 commit into
slidevjs:mainfrom
exKAZUu:fix/client-declare-markdown-it-github-alerts
Open

fix(client): declare markdown-it-github-alerts as a dependency#2719
exKAZUu wants to merge 1 commit into
slidevjs:mainfrom
exKAZUu:fix/client-declare-markdown-it-github-alerts

Conversation

@exKAZUu

@exKAZUu exKAZUu commented Aug 25, 2026

Copy link
Copy Markdown

Description

packages/client/styles/index.ts imports the stylesheets of markdown-it-github-alerts (since #2547):

import 'markdown-it-github-alerts/styles/github-colors-light.css'
import 'markdown-it-github-alerts/styles/github-colors-dark-media.css'
import 'markdown-it-github-alerts/styles/github-base.css'

but @slidev/client only gets the package through hoisting: it is declared in packages/slidev/package.json, not in packages/client/package.json. With a package manager layout that does not hoist transitive dependencies next to @slidev/client (e.g. Bun's isolated linker with its global store, where each package can only see its declared dependencies), slidev build fails with:

Error: [vite]: Rolldown failed to resolve import "markdown-it-github-alerts/styles/github-colors-light.css" from ".../node_modules/@slidev/client/styles/index.ts".

This PR declares markdown-it-github-alerts in @slidev/client via the existing catalog:prod entry, so the import resolves regardless of hoisting. pnpm verify passes locally.

Linked Issues

Related to #2547 (which introduced the import).

Additional context

Reproduced with @slidev/cli@52.19.0 installed by Bun 1.4.0 with linker = "isolated" and globalStore = true.

@netlify

netlify Bot commented Aug 25, 2026

Copy link
Copy Markdown

Deploy Preview for slidev ready!

Name Link
🔨 Latest commit 6cb0642
🔍 Latest deploy log https://app.netlify.com/projects/slidev/deploys/6a8da5438decea0008221fb3
😎 Deploy Preview https://deploy-preview-2719--slidev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant