Feat: refactor with sorting fix #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spectator role addition and performance enhancements
Fix: created at index
Perf: added lean to a few queries
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Co-authored-by: Copilot <[email protected]>
Feat: added database level auditing
Member
|
Changes look good @icy-r . I updated the path of the bulk update endpoint and also added creator lock into it. Merging now and testing in staging before release |
Akalanka47000
approved these changes
Nov 29, 2025
| await sendUserPassword(payload.email, generatedPassword, payload.role); | ||
| return newUser; | ||
| } catch (e) { | ||
| findOneAndRemoveUser({ email: payload.email }).exec(); |
Member
There was a problem hiding this comment.
@icy-r this will not run without the exec call. This returns a query instance which we must either await or use exec on to actually execute the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new bulk update feature for question status, refines validation and error handling, and makes minor improvements to existing logic. The most significant change is the addition of an endpoint and service logic to enable or disable all questions at once. Other updates include improved validation for settings and user verification, and minor code quality enhancements.
Bulk question status update:
bulkUpdateStatuscontroller and corresponding service (bulkUpdateQuestionStatus) to enable/disable all questions at once (src/controllers/question.js,src/services/question.js,src/repository/question/index.js,src/routes/question.routes.js,src/validations/question.js). [1] [2] [3] [4] [5] [6] [7] [8]PATCH /questions/bulk/statusfor admins, with schema validation (bulkUpdateStatusSchema) for theenabledfield (src/routes/question.routes.js,src/validations/question.js). [1] [2]Validation and error handling improvements:
resendVerificationcontroller to throw a 404 error if the user is not found (src/controllers/auth.js).src/routes/setting.routes.js,src/controllers/settings.js). [1] [2]Minor code quality and bug fixes:
src/services/leaderboard.js).pickimport fromlodashinsrc/app.js..exec()call (src/services/user.js).upsertoption in submission grading update (src/repository/submission.js).