feat: Integrate ThemeToggle component into Navbar with improved styling#50
feat: Integrate ThemeToggle component into Navbar with improved styling#50MrVirul wants to merge 4 commits intosliit-foss:mainfrom
Conversation
There was a problem hiding this comment.
remove commented imports
Since I'm no longer maintaining this get a review from @SayuruRehan
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the ThemeToggle component directly into the Navbar component, improving the user experience by placing the theme toggle in a more accessible location. The changes also enhance the visual styling for better contrast in dark mode.
- Moved ThemeToggle from a standalone section to the navigation bar
- Enhanced dark mode styling with improved color contrast
- Simplified the component structure by removing unnecessary wrapper elements
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/ui/ThemeToggle.scss | Updated dark theme styling with better color contrast |
| src/components/Common/Navbar/Navbar.tsx | Added ThemeToggle integration with props interface |
| src/App.tsx | Removed standalone ThemeToggle section and passed props to Navbar |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @SayuruRehan, thanks for the feedback! I've pushed the fix to remove the unused imports. As this is my first open-source contribution, I'm still learning the best practices. My apologies for using the main branch for this PR; I'll be sure to use a separate feature branch for any future contributions. Let me know if anything else is needed! |
I've moved the light/dark mode theme toggle button into the navigation bar at the top of the page. I also improved the colors to make it look better, especially in dark mode.
Changes
Moved the Button: The theme toggle button is now part of the main navigation bar.
Improved Dark Mode Colors: I updated the styling to make the button have better contrast when the dark theme is active.
Cleaned Up Code: I removed some unnecessary wrapper components to make the code simpler.

