Normalize splatted merge arrays like explicit attributes - #980
Open
OskarEichler wants to merge 1 commit into
Open
Normalize splatted merge arrays like explicit attributes#980OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize arrays used in splatted mergeable attributes the same way as explicit attributes: flatten, convert elements to strings, remove empty values, then join. This also omits an attribute when the resulting value is empty.
Reproduction
Before: direct output has
class="a b", splatted output hasclass="a b ". An all-empty splat array producesclass=" "rather than omitting the attribute. After: both paths match. Existing conversion of true/false to strings within merge arrays is unchanged.Verification
Compatibility / limitations
No API removal or dependency upgrade. Output intentionally changes for splatted merge arrays containing empty/nil nested values; code relying on extra whitespace or empty pieces with custom delimiters should account for this. This follows the existing direct-attribute semantics. General data/aria boolean policy (#872/#974) is unchanged.