Evaluate static translation interpolations once in source order - #982
Open
OskarEichler wants to merge 1 commit into
Open
Evaluate static translation interpolations once in source order#982OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evaluate interpolations once, in source order, when using static translation. Capture their rendered values before substituting translated placeholders, matching the existing dynamic translation semantics.
Reproduction
For
p #{next_value}, let the translator repeat%1as%1 %1, and let next_value increment a counter. Static mode currently renders<p>1 2</p>while dynamic mode renders<p>1 1</p>. Reordering or dropping translated placeholders likewise reorders or omits expression evaluation in static mode. After this patch both modes evaluate source expressions once in source order.Verification
Compatibility / limitations
No API removal or dependency upgrade. Behavior change: interpolation side effects now happen once in source order, including when a translation omits a placeholder. Applications relying on repeated/skipped/reordered evaluation in static mode will observe the corrected behavior. Translation itself still happens at compile time in static mode.