[clippy] use is_multiple_of instead of "foo % 3 == 0"#10457
Open
Montel wants to merge 1 commit intoslint-ui:masterfrom
Open
[clippy] use is_multiple_of instead of "foo % 3 == 0"#10457Montel wants to merge 1 commit intoslint-ui:masterfrom
Montel wants to merge 1 commit intoslint-ui:masterfrom
Conversation
ogoffart
reviewed
Jan 16, 2026
| match list_item_type { | ||
| Some(ListItemType::Unordered) => { | ||
| if indentation % 3 == 0 { | ||
| if indentation.is_multiple_of(3) { |
Member
There was a problem hiding this comment.
This is not consistent with the condition two lines bellow. But OK
Member
There was a problem hiding this comment.
I'd also prefer to keep it consistent. Another option would be store the remainder of the division in a variable and then use that in the if - for readability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.