Skip to content

material-gallery signed aab#10582

Open
burhankhanzada wants to merge 1 commit intoslint-ui:masterfrom
burhankhanzada:material-gallery-sign-aab
Open

material-gallery signed aab#10582
burhankhanzada wants to merge 1 commit intoslint-ui:masterfrom
burhankhanzada:material-gallery-sign-aab

Conversation

@burhankhanzada
Copy link
Member

No description provided.

@burhankhanzada
Copy link
Member Author

burhankhanzada commented Jan 28, 2026

@tronical We need ANDROID_KEYSTORE_ALIAS for it

@tronical
Copy link
Member

@tronical We need ANDROID_KEYSTORE_ALIAS for it

I don't know what the value of the variable needs to be. @ogoffart does that ring a bell for you?

@burhankhanzada
Copy link
Member Author

@NigelBreslaw may be you know?

@ogoffart
Copy link
Member

They keystore alias is not a secret. I think I used the default value when generating the key. Or left it empty.

@ogoffart
Copy link
Member

I found the command I used to to create the key:

keytool -genkey -v -keystore github.keystore -alias my-key-alias -keyalg RSA -keysize 2048 -validity 10000

So looks like the alias is my-key-alias

@tronical
Copy link
Member

Thanks. Not much of a secret but I've set it in the org now. So I think what's left is either adjusting the workflow that calls this one to pass the secret or using it plain :)

@NigelBreslaw
Copy link
Member

I have changed the key on the store site. So the old one needs replacing in the secrets. It felt like a massive amount of time was being spent here so I just went and fixed it. I think I can just take over this PR later because there are other issues such as xbuild using an outdated NDK that Google no longer accept. There is no urgency now the account won't be closed, right? I will take this on once the EW tasks are done.

@burhankhanzada
Copy link
Member Author

I have changed the key on the store site. So the old one needs replacing in the secrets. It felt like a massive amount of time was being spent here so I just went and fixed it. I think I can just take over this PR later because there are other issues such as xbuild using an outdated NDK that Google no longer accept. There is no urgency now the account won't be closed, right? I will take this on once the EW tasks are done.

Yeah i try to fix xbuild but there is too much to do coz it havent updated much and doesent support aab signing

@NigelBreslaw
Copy link
Member

Just leave it for now and pass it to me. To get this all working you need to also be in the google play store account. Thanks for getting it this far and sorting out the aab build. I can now make the google play console gods happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants