GridLayout: support for nested repeaters#10885
Open
dfaure-kdab wants to merge 3 commits intoslint-ui:masterfrom
Open
GridLayout: support for nested repeaters#10885dfaure-kdab wants to merge 3 commits intoslint-ui:masterfrom
dfaure-kdab wants to merge 3 commits intoslint-ui:masterfrom
Conversation
dfaure-kdab
force-pushed
the
wip/dfaure/gridlayout-nested-repeaters-v2
branch
from
b409844 to
f184a1d
Compare
This uses the new cache format introduced by a recent commit for this purpose. In this commit, it is assumed that all nested repeaters produce the same number of items. This is very temporary, a followup commit will handle that case properly. Fixes slint-ui#10670
Visually, it looks exactly like grid-with-repeated-rows.slint but the model is an array of arrays instead of being an array of structs.
dfaure-kdab
force-pushed
the
wip/dfaure/gridlayout-nested-repeaters-v2
branch
from
f184a1d to
72879b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the new cache format introduced by a recent commit for this purpose.
In this commit, it is assumed that all nested repeaters produce the same number of items. This is very temporary, a followup commit will handle that case properly.
Fixes #10670