cpp: Fix compiler not supporting experimental features#10981
Open
ubruhin wants to merge 1 commit intoslint-ui:masterfrom
Open
cpp: Fix compiler not supporting experimental features#10981ubruhin wants to merge 1 commit intoslint-ui:masterfrom
ubruhin wants to merge 1 commit intoslint-ui:masterfrom
Conversation
It was already possible to set SLINT_FEATURE_EXPERIMENTAL=ON from CMake, but this effectively didn't run the Slint compiler with the environment variable SLINT_ENABLE_EXPERIMENTAL_FEATURES=1. So it was not possible to use experimental features like DragArea. This patch will set that environment variable if experimental features are enabled in CMake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was already possible to set
SLINT_FEATURE_EXPERIMENTAL=ONfrom CMake, but this effectively didn't run the Slint compiler with the environment variableSLINT_ENABLE_EXPERIMENTAL_FEATURES=1. So it was not possible to use experimental features likeDragArea. This patch will set that environment variable if experimental features are enabled in CMake.We already had this patch for a long time in LibrePCB, so I thought it's time to contribute it upstream ;)
I hope this is a desired change. Just let me know if I should change anything.