Qt: Fix including GL/gl.h through Qt headers#10990
Open
ubruhin wants to merge 1 commit intoslint-ui:masterfrom
Open
Qt: Fix including GL/gl.h through Qt headers#10990ubruhin wants to merge 1 commit intoslint-ui:masterfrom
ubruhin wants to merge 1 commit intoslint-ui:masterfrom
Conversation
Make sure that GL/gl.h is never included, as this would lead to compile errors on systems where this file is not found. Fixes slint-ui#10989
ubruhin
force-pushed
the
fix-qt-opengl-include
branch
from
e8122df to
7f6d238
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure that
GL/gl.his never included, as this would lead to compile errors on systems where this file is not found.I did not only remove the
#include <QtWidgets/QtWidgets>which caused the problem, but also now passing-DQT_NO_OPENGLto be really sure the same problem doesn't (accidentally) occur again. I verified that-DQT_NO_OPENGLalone would already fix the compile error on OpenBSD.Fixes #10989