Encapsulate Element::bindings - #12655
Open
LeonMatthes wants to merge 14 commits into
Open
Conversation
tronical
reviewed
Jul 27, 2026
LeonMatthes
force-pushed
the
debug-hook-aware-bindings-api
branch
2 times, most recently
from
July 28, 2026 07:29
8e794be to
0631dc7
Compare
This allows us to make the map itself private while still keeping the member public, which is important so that we can use struct literal syntax to construct Element.
LeonMatthes
force-pushed
the
debug-hook-aware-bindings-api
branch
from
July 28, 2026 07:30
0631dc7 to
fda07dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the initial debug hooks PR.
As noted during this PR, we probably want to make the bindings fully
private and go through an accessor API. This PR makes that change.