Quote visibility in diagnostics - #12669
Open
0x6e wants to merge 9 commits into
Open
Conversation
Now that we use the actual syntax here, lets quote it to make it clear it is syntax.
Emphasise the syntax that might be causing the problem.
Match the style of the other diagnostics printing visibility. Use the Display implementation of PropertyVisbility::Output so that the error text is kept up-to-date in the future.
Highlight the syntax now that input/output have been changed to `in`/`out`.
Highlight the syntax, and use "an" here as it sounds more natural.
…rnings Quote the visibility to match the style of other diagnostics.
Match the style of the other visibility diagnostics. Use the Display implementation for PropertyVisibility so that the diagnostics are consistent.
…ion warnings Match the style of the other visibility diagnostics.
Match the style of other visibility diagnostic.
tronical
force-pushed
the
nathan/visibility-diagnostic-quotes
branch
from
July 28, 2026 11:01
6d2b69e to
1c47be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #12592 where the display implementation for Input, Output, InOut visibilities was updated to use the expected syntax:
in,out,in-out.Now we quote the visibility in diagnostics to highlight the syntax.