compiler: Make langtype::Type Send - #12678
Merged
Merged
Conversation
The Type/Struct/Enumeration/NativeClass/Function types and their construction sites now use Arc so that the LLR CompilationUnit can eventually be made Send and moved to another thread.
Switch SourceFile from Rc to Arc and SourceFileInner::line_offsets from OnceCell to OnceLock, so SourceLocation (and the LLR debug info that holds it) becomes Send + Sync.
The rowan red syntax node stored on StructName::User and Enumeration is not Send. Replace it with a DeclNode that keeps only the source file and the declaration's text range, and capture what the code generators need (the @rust-attr text, and the field declaration order for C++) into the type at build time. The language server resolves the actual syntax node from its own DocumentCache. The langtype graph thus carries no syntax tree and becomes Send.
The BUILTIN, BUILTIN_STRUCTS, RESERVED_PROPERTIES and BuiltinFunction type caches were thread_local only because they held Rc, which is not Sync. Now that they hold Arc, make them global LazyLock statics so the builtin structs and enums have a single process-wide identity. This matches the threaded compilation model: a type built on the compile worker thread and one built on the main thread now share the same allocation, so Arc::ptr_eq stays consistent across threads.
ogoffart
force-pushed
the
olivier/langtype-send
branch
from
July 28, 2026 16:16
9ed9fd9 to
6dc5b12
Compare
tronical
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a first step to get the LLR Send.
The most annoying part is the "make struct/enum declaration nodes Send" commit, because the Struct and Enum contains a SyntaxNode.