Conversation
…rpus
The completeness check skipped them: the rendering and generated-code
chapters went unchecked for missing `{#sls.…}` markers, and the 14 they
carried were stripped instead of becoming anchors.
Treat the manual's `reference/` as normative, with a `normative: false`
opt-out for navigational pages.
starlight-links-validator skips relative links, so the matrix's 92 anchor citations went unchecked and could rot into dead anchors unnoticed. Emit the page URLs from the site base, read from safety-site-config.mjs.
starlight-links-validator skips relative links, so these 13 went unchecked. Write them from the site base instead.
The specification chapters were the last with relative, unchecked links, and they must stay relative where the main documentation resolves them too. Rewrite them from the site base while syncing, drop `<NotInSC>` blocks there (they link to chapters the manual doesn't serve) as the property-types pages already do, and turn on `errorOnRelativeLinks`.
ogoffart
approved these changes
Jul 29, 2026
Astro doesn't apply `base` to markdown links, so writing them from the site root broke the deployed build, which serves the manual under a versioned path: link validation rejected all 13 as pointing nowhere. Add the base in a remark plugin instead, ahead of the validator's rehype pass, and let every source keep writing links from the site root.
tronical
enabled auto-merge (rebase)
July 29, 2026 14:06
ogoffart
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two guards in the safety manual were silently ineffective.
The
{#sls.…}completeness check skipped the manual's own reference chapters, sorenderingandgenerated-codewent unchecked for missing markers, and the 14they carried were stripped rather than turned into anchors. The traceability
matrix cited all 14 anyway, as dead links.
Nothing caught that, because
starlight-links-validatorskips relative linksinstead of resolving them, and every internal link in the manual was relative.
Now the manual's
reference/counts as normative, and every internal link iswritten from the site base so the validator that already runs actually checks it.
With nothing relative left,
errorOnRelativeLinksis on, so a link that can't bechecked fails the build.
Coverage moves to 65 of 92 requirement paragraphs: the completeness check caught
two untagged normative paragraphs, which are now identified but not yet tested.