Add functional and database compatibility test coverage - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The app is already shipped, so both runtime controller behavior and persisted-data compatibility need stable regression coverage. Historical database fixtures provide an upgrade oracle independent of the current schema, while the controller tests exercise real branching and async behavior instead of only construction or static constants.
Impact
There is no database version bump in this PR. Existing schema v3 and v4 databases continue upgrading through the current v4 migration. In-progress subtitle state can now survive an app restart. The controller changes also prevent null subscription identifiers from matching, duplicate in-flight translation requests, starvation of later translation work after one failure, and leaked player timers/audio subscriptions.
Validation
flutter pub get --enforce-lockfileflutter analyze --no-fatal-infos(passes; 12 pre-existing info-level lints)flutter test --coverage— 78 tests passed