Make the first exp of retry with backoff be 0#29
Open
lahiguera wants to merge 1 commit intoslok:masterfrom
Open
Make the first exp of retry with backoff be 0#29lahiguera wants to merge 1 commit intoslok:masterfrom
lahiguera wants to merge 1 commit intoslok:masterfrom
Conversation
Context:
--------
Previously the first exponent used to calculate the first waiting
time when retrying using the expoential backoff algorithm with
full jitter was 1, i.e. 2**1 was used instead of 2**0. This made
the first waiting time longer (only potentially because of jitter)
than what it's supposed to be.
Also previously the tests in `retry_test.go` that relied on
`patternTimer` were not actually testing anything, since the `Run`
method of such struct preventing the recording of the waiting times
because `prevExecution` was always equal to time.Time{}.
This PR fixes the issues mentioned above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Previously the first exponent used to calculate the first waiting
time when retrying using the expoential backoff algorithm with
full jitter was 1, i.e.
2**1was used instead of2**0. This madethe first waiting time longer (only potentially because of jitter)
than what it's supposed to be.
Also previously the tests in
retry_test.gothat relied onpatternTimerwere not actually testing anything, since theRunmethod of such struct prevented the recording of the waiting times
because
prevExecutionwas always equal totime.Time{}.This PR fixes the issues mentioned above.