chore: update Python versions and CI#486
Merged
sloria merged 7 commits intosloria:devfrom Jan 13, 2025
johnfraney:update-python-versions
Merged
chore: update Python versions and CI#486sloria merged 7 commits intosloria:devfrom johnfraney:update-python-versions
sloria merged 7 commits intosloria:devfrom
johnfraney:update-python-versions
Conversation
Updates supported Python versions to be 3.9-3.13 and updates CI to use the built-in textblob.download_corpora command
sloria
requested changes
Jan 13, 2025
Owner
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
thank you! been meaning to get to this for a while but haven't had the time.
once lowest is added back, this should be good to merge!
Adds back the "lowest" env in Tox/CI to ensure support in the lowest supported Python + NLTK versions
sloria
approved these changes
Jan 13, 2025
Owner
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
looks great! thanks so much.
i'll fix up the branch rules and merge this later today. in the meantime, can you add yourself to AUTHORS.rst please?
Contributor
Author
|
@sloria Oh! You bet. I'll do that now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates supported Python versions to be 3.9-3.13 and updates CI to use the built-in
textblob.download_corporacommand. Also updates corpora module names to fix a missing corpora error when running:python -m textblob.download_corpora
Notes
This should fix CI errors and #482 and #474 but removes NLTK v3.8 support
This requires updating the repo's required status checks to be Python 3.9 and 3.13