Skip to content

feat: Bazel not experimental #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonpetgrave64 merged 5 commits into from
Jun 23, 2025
Merged

feat: Bazel not experimental #850

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8fe548a
bazel not experimental
ramonpetgrave64 Jun 10, 2025
40f0c91
fix imports
ramonpetgrave64 Jun 10, 2025
0db0ca2
Merge branch 'main' into bazel-not-experimental
ramonpetgrave64 Jun 20, 2025
77b5e98
Update verify.go
ramonpetgrave64 Jun 20, 2025
48d3e12
capitalize GitHub
ramonpetgrave64 Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cli/slsa-verifier/main_regression_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,6 @@ func Test_runVerifyGHAContainerBased(t *testing.T) {

func Test_runVerifyGithubAttestation(t *testing.T) {
t.Parallel()
os.Setenv("SLSA_VERIFIER_EXPERIMENTAL", "1")

bcrReleaserBuilderID := "https://github.com/bazel-contrib/.github/.github/workflows/release_ruleset.yaml"
bcrPublisherBuilderID := "https://github.com/bazel-contrib/publish-to-bcr/.github/workflows/publish.yaml"
Expand Down
2 changes: 1 addition & 1 deletion cli/slsa-verifier/verify.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func verifyGithubAttestation() *cobra.Command {
}
return nil
},
Short: "Verifies SLSA provenance for a github attestation [experimental]",
Short: "Verifies SLSA provenance for a github attestation",
Run: func(cmd *cobra.Command, args []string) {
v := verify.VerifyGithubAttestationCommand{
AttestationPath: o.AttestationPath,
Expand Down
7 changes: 0 additions & 7 deletions cli/slsa-verifier/verify/verify_github_attestation.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ package verify
import (
"context"
"crypto/sha256"
"errors"
"fmt"
"os"

Expand All @@ -35,12 +34,6 @@ type VerifyGithubAttestationCommand struct {
}

func (c *VerifyGithubAttestationCommand) Exec(ctx context.Context, artifact string) (*utils.TrustedBuilderID, error) {
if !options.ExperimentalEnabled() {
err := errors.New("feature support is only provided in SLSA_VERIFIER_EXPERIMENTAL mode")
fmt.Fprintf(os.Stderr, "Verifying github attestation: FAILED: %v\n\n", err)
return nil, err
}

artifactHash, err := computeFileHash(artifact, sha256.New())
if err != nil {
fmt.Fprintf(os.Stderr, "Verifying artifact %s: FAILED: %v\n\n", artifact, err)
Expand Down
Loading