content: draft: Moved example to a new threat. #1250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was in the wrong place. It had been under a threat that was meant for attackers that modified signed attestations, yet it discussed replacing one valid attestation with another. There wasn't an obivious existing threat to put this under so I created a new one. refs slsa-framework#1191 Signed-off-by: Tom Hennen <[email protected]>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TomHennen
changed the title
trishankatdatadog
approved these changes
Dec 3, 2024
arewm
reviewed
Dec 4, 2024
zachariahcox
reviewed
Dec 4, 2024
zachariahcox
approved these changes
Dec 4, 2024
Co-authored-by: Zachariah Cox <[email protected]> Signed-off-by: Tom Hennen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was in the wrong place. It had been under a threat that was meant for attackers that modified signed attestations, yet it discussed replacing one valid attestation with another.
There wasn't an obivious existing threat to put this under so I created a new one.
fixes #1223