Skip to content

fix: 1.1 rc2 run grammar check and fix typos. #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix: 1.1 rc2 run grammar check and fix typos. #1320

merged 1 commit into from
Apr 8, 2025

Conversation

zachariahcox
Copy link
Contributor

This PR should introduce no change to the meaning of any sentence.

@github-project-automation github-project-automation bot moved this to 🆕 New in Issue triage Apr 7, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 7, 2025 •
edited
Loading

✅ Deploy Preview for slsa ready!

Name Link
🔨 Latest commit 30ce217
🔍 Latest deploy log https://app.netlify.com/sites/slsa/deploys/67f440e61dd9610008d5c275
😎 Deploy Preview https://deploy-preview-1320--slsa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arewm
arewm approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@arewm arewm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! It looks like we need a grammar linter. :)

lehors
lehors approved these changes Apr 8, 2025
View reviewed changes
Copy link
Member

@lehors lehors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the careful nit picking! This should clearly be labelled as a fix rather than a content change though.

@lehors lehors changed the title content: 1.1 rc2 run grammar check and fix typos. fix: 1.1 rc2 run grammar check and fix typos. Apr 8, 2025
@lehors lehors merged commit 9e01280 into slsa-framework:main Apr 8, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Issue triage Apr 8, 2025
@zachariahcox
Copy link
Contributor Author

zachariahcox commented Apr 8, 2025 •
edited
Loading

This should clearly be labelled as a fix rather than a content change though.

Aha! I didn't know about that prefix. Thanks!

@zachariahcox zachariahcox deleted the users/zacox/typos11rc2 branch April 12, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehors lehors lehors approved these changes

@arewm arewm arewm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issue triage
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zachariahcox @lehors @arewm