Remove dependency to slub_digitalcollections #257
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christos Sidiropoulos <[email protected]>
- Remove extension ref Signed-off-by: Christos Sidiropoulos <[email protected]>
- Remove namespaces - Route references to future classes in dfg-viewer Signed-off-by: Christos Sidiropoulos <[email protected]>
TODO: Licence okay? Signed-off-by: Christos Sidiropoulos <[email protected]>
TODO: Licence okay? Signed-off-by: Christos Sidiropoulos <[email protected]>
Contributor
|
Thanks for your work! Here you can see how should like corrected version for errors mentioned by PHPStan: https://github.com/slub/slub_digitalcollections/pull/62/files#diff-15fcbab3d3cc1b4c3b8bc8a6b789d6da89d5a731cebdb8929b49fec8de86dcac I will look for some examples of 3D Viewer and Calendar, then write you back again. |
beatrycze-volk
added
the
🛠️ maintenance
See PR slub/slub_digitalcollections#62 And tree https://github.com/beatrycze-volk/slub_digitalcollections/tree/phpstan Signed-off-by: Christos Sidiropoulos <[email protected]>
Signed-off-by: Christos Sidiropoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #253, this draft intended to remove the dependencies on slub_digitalcollections.
I removed every trace and reference to the digitalcollections and where needed set new paths that lead within the repo. Than I copied missing files and updated some already existing. I tried to compare the commit dates and check it its working because I wasn't sure with the typoscript.
For future reference: digitalcollections state at this moment is following commit slub/slub_digitalcollections@d511e7e. I did not copy the history. That exceeded my capabilities and I didn't want to spend hours going through and cleaning up commits. Hopefully this is okay.
Btw. we should take a look at the licences, because some of the files have a copyright notice.
At this moment everything I've tested is working fine. Which does obviously not mean that I didn't miss a lot or broke something!
Working:
What's not working:
Happy to get feedback and am looking forward to your corrections