Skip to content

Conversation

@rettinghaus
Copy link
Contributor

This PR is another step to close #21.

Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, much appreciated!

Just 2 caveats... would you like me to address these, or rather fix them yourself?

Copy link
Member

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@bertsky
Copy link
Member

bertsky commented Sep 25, 2025

I would like to rebase so we get a cleaner history from this:

Naturally, this would involve a force-push afterwards. Can I do it myself on your branch, or in a new PR, or would you kindly do that, too?

@bertsky bertsky merged commit ee05c00 into slub:master Sep 25, 2025
4 checks passed
@rettinghaus rettinghaus deleted the PEP257 branch September 25, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be as pythonic as possible

2 participants