-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added a lite option to remove content #2785
Conversation
Hey, John need to take a look and review your merge request. He will it soon but not today. Thank you so much for your contribute. Feel free to improve it as much as you can. John is a special man. |
Hi there, happy to see you are helping to the project. It's great. You need to do some changes, then we can approve and merge your changes. You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version? |
as asked ive removed content from the new code and enhanced the old code please review and merge 🙏🙏🙏 |
Thanks. |
@jbampton please merge and close🙏🙏🙏 |
Thanks and well done.
I tested locally and it seems to work fine.
Ready for approval and then merge
…On Sun, 6 Oct 2024 at 23:27, Dxuian ***@***.***> wrote:
@jbampton <https://github.com/jbampton> please review and merge 🙏🙏🙏
—
Reply to this email directly, view it on GitHub
<#2785 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE3LEGW2UWIO7RD73XMRMIDZ2E3FDAVCNFSM6AAAAABPMKI2ZCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGQ2DANRSG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - from John
Many thanks and well done |
in reference to #2393
added a discard content boolean option