Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a lite option to remove content #2785

Merged
merged 3 commits into from
Oct 6, 2024
Merged

added a lite option to remove content #2785

merged 3 commits into from
Oct 6, 2024

Conversation

Dxuian
Copy link
Contributor

@Dxuian Dxuian commented Oct 4, 2024

in reference to #2393
added a discard content boolean option

@BaseMax
Copy link
Member

BaseMax commented Oct 4, 2024

Hey, John need to take a look and review your merge request. He will it soon but not today.

Thank you so much for your contribute. Feel free to improve it as much as you can. John is a special man.

@BaseMax
Copy link
Member

BaseMax commented Oct 6, 2024

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 6, 2024

Hi there, happy to see you are helping to the project. It's great.

You need to do some changes, then we can approve and merge your changes.

You needs to remove "content" from the results array. you has the test for the "lite" version. Lite version does not include content. It is not the best approach but helps and we can modify later. Can you please results array needs no content for the lite version?

as asked ive removed content from the new code and enhanced the old code please review and merge 🙏🙏🙏

@BaseMax
Copy link
Member

BaseMax commented Oct 6, 2024

Thanks.

@Dxuian
Copy link
Contributor Author

Dxuian commented Oct 6, 2024

@jbampton please merge and close🙏🙏🙏

@johnbampton
Copy link
Member

johnbampton commented Oct 6, 2024 via email

Copy link
Member

@BaseMax BaseMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - from John

@BaseMax BaseMax merged commit cd3f201 into slurpcode:main Oct 6, 2024
25 of 35 checks passed
@BaseMax
Copy link
Member

BaseMax commented Oct 6, 2024

Many thanks and well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants