Skip to content

fix: use retraction_reason in file view alert #410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

crfmc
Copy link
Collaborator

@crfmc crfmc commented Apr 28, 2025

  • Use retraction_reason property to create file overview alert string instead of notes_to_tsv

crfmc added 2 commits April 28, 2025 12:11
- fix: remove from accessionsOfInterest array
- feat: add retraction reason to string
@crfmc
Copy link
Collaborator Author

crfmc commented Apr 28, 2025

@crfmc crfmc requested a review from Copilot April 28, 2025 16:34
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the file view alert to use the retraction_reason property instead of notes_to_tsv and refines the alert rendering conditions. Key changes include:

  • Using retraction_reason to construct the retracted warning message.
  • Adjusting the accessionsOfInterest list to only include one accession.
  • Bumping the project version in pyproject.toml.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/encoded/static/components/item-pages/FileView.js Updated alert logic to use retraction_reason and modified conditions.
pyproject.toml Incremented version from 0.165.0 to 0.165.1 to reflect the changes.
Files not reviewed (1)
  • CHANGELOG.rst: Language not supported
Comments suppressed due to low confidence (2)

src/encoded/static/components/item-pages/FileView.js:104

  • Remove or disable the console.log used for debugging to avoid unintended log output in production.
console.log('context', context);

src/encoded/static/components/item-pages/FileView.js:102

  • Review the removal of 'SMAFI557D2E7' from the accessionsOfInterest list to ensure the alert behavior remains as intended.
const accessionsOfInterest = ['SMAFIB6EQLZM'];

@crfmc crfmc requested a review from utku-ozturk April 30, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant