SN Update column mappings #21
Conversation
wfeng19
left a comment
wfeng19
left a comment
There was a problem hiding this comment.
Besides a couple of typos, everything looks good to me!
| "DuplexSeq_ExternalQualityMetric": "duplexseq_external_quality_metric", | ||
| "DSA_ExternalQualityMetric": "dsa_external_quality_metric" | ||
| }, | ||
| "column_mappings": { |
There was a problem hiding this comment.
Dominik provided recommendations for new descriptions for a couple of the items on this Google Sheets. Many of them seem more like they are describing the importance of the metric and not the metric itself, so I'm not sure how many we want to use, but some could be helpful to add!
There was a problem hiding this comment.
It seems you regenerated this file using an older version of Poetry. The version in the MAKEFILE is 1.8.4 and ideally that should be used to generate the poetry.lock
| "DSA_ExternalQualityMetric": "dsa_external_quality_metric" | ||
| }, | ||
| "column_mappings": { | ||
| "external_quality_metric": { |
There was a problem hiding this comment.
Is this a breaking change or has this functionality not been used before? Will older spreadsheets still work?
There was a problem hiding this comment.
This functionality hasn't been used before. This was something David has made as a template, but that we haven't actually taken in any submissions with
pyproject.toml
Outdated
| [tool.poetry] | ||
| name = "smaht-submitr" | ||
| version = "1.6.3" | ||
| version = "1.6.4" |
There was a problem hiding this comment.
Maybe a minor version change is appropriate? (I assume there is no breaking change)
custom_column_mappingsto include values for both DuplexSeq_ExternalQualityMetrics and DSA_ExternalQualityMetrics