fix(getting_started): unpin 4.4.7 — validator ERROR is misleading but harmless#61
Merged
Merged
Conversation
… harmless PR #50 pinned smallestai<4.4.7. Re-verified on smallestai==4.4.7: Boot log: ERROR Startup validation failed — pod will not accept sessions. ValueError: Session not initialized INFO Application startup complete. INFO Uvicorn running on http://0.0.0.0:8080 Real handshake (via ChatClient): ✓ Connected and ready! Session complete. The validator dry-runs setup_handler against a null WebSocket, always trips on `await session.start()`, and prints the traceback at ERROR level. The pod still accepts sessions and the agent runs normally. Pinning <4.4.7 broke the parallel background_agent example (which needs SDKAgentLogEvent from 4.4.7). Net negative. Drop the upper bound; keep an inline comment explaining the noisy boot log so customers don't file bugs. Verification log: /Users/tunejedi/Projects/smallest_work/verifications/sprint-31-unpin-447.log
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…l voice
Drop conversational framing ('misleading', 'safe to ignore', 'works
despite the message'). State the routine, the log line, and that the
server continues. The underlying log-message wording is a separate
SDK concern; doc/example comments should describe observed behavior
technically, not editorialize.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts PR #50's
smallestai<4.4.7pin. Re-verified end-to-end onsmallestai==4.4.7: the new startup validator logs a scaryValueError: Session not initializedERROR + traceback, but the pod still accepts sessions and the agent runs normally.What I tested
Boot log:
Real WebSocket handshake (via
smallestai.cli.lib.chat.ChatClient):The validator phrase "pod will not accept sessions" is wrong in the log — the pod does accept sessions. It's a dry-run hook that calls user's
setup_handleragainst a null WebSocket; every example'sawait session.start()raises during validation, but real connections work fine.Why we pinned in the first place (and why it was wrong)
The pin in PR #50 came from a single observation that boot looked broken. I missed the
Application startup complete.line a few lines below the ERROR. Bot review on the docs PR #164 (entelligence-ai) flagged the contradiction: pinning broke the parallelbackground_agentexample (which needsSDKAgentLogEventfrom 4.4.7). Net negative.Changes
voice-agents/getting_started/requirements.txt: drop the<4.4.7upper boundbackground_agent/requirements.txtalready pinned>=4.4.7(which is correct — it needsSDKAgentLogEvent); leaving as-is.Test plan
cd voice-agents/getting_started && pip install -r requirements.txtresolves to latestsmallestai>=4.4.6(currently 4.4.7)python server.pyreaches "Application startup complete." (verified)agent-crew chatconnects + handshake completes (verified)Companion docs PR
smallest-inc/smallest-ai-documentationPR (link incoming) — same revert + adds an explainer Warning in the Installation section.