Skip to content

Conversation

@VonRehberg
Copy link

Name of feature: Allow active revocation via http endpoint

Pain or issue this feature alleviates: active revocation was already possible via cli but not via http

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Nov 28, 2024
@hslatman hslatman self-assigned this Dec 3, 2024
@hslatman
Copy link
Member

hslatman commented Dec 12, 2024

Hey @VonRehberg, thank you for the PR.

Can you remove the test at

"error/non-passive not implemented": {
rr: &RevokeRequest{
Serial: "10",
ReasonCode: 8,
Passive: false,
},
err: &errs.Error{Err: errors.New("non-passive revocation not implemented"), Status: http.StatusNotImplemented},
},
?

From the looks of it the change looks OK. It seems to stem from the time we only supported passive revocation, but since then support for active revocation was added by the community. In practice the way that is configured and works does seem to make the Passive boolean obsolete, and it seems to be just informational at the moment. I think there's improvements that can be done, but that would require some more work to feed it through, and doesn't need to be in this PR.

@tacerus
Copy link

tacerus commented Jul 6, 2025

Hi, as this seemed to be stale I continued in #2327.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants