Skip to content

Conversation

@marioja
Copy link

@marioja marioja commented May 26, 2025

…rors

Name of feature:

Added test for the StoreProvisioner method

Pain or issue this feature alleviates:

Why is this important to the project (if not answered above):

Is there documentation on how to use this feature? If so, where?

In what environments or workflows is this feature supported?

In what environments or workflows is this feature explicitly NOT supported (if any)?

Supporting links/other PRs/issues:

💔Thank you!

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label May 26, 2025
@hslatman hslatman requested a review from dopey May 27, 2025 17:21
@dopey
Copy link
Contributor

dopey commented May 27, 2025

Hey @marioja 👋. Thanks for opening the issue!

I understand the additional test coverage for the StoreProvisioner method - thanks for adding that!

Can you please explain the changes in the testAuthority function? https://github.com/smallstep/certificates/pull/2284/files#diff-efd742a0f56eda5c2aba7508dc0dbac4ffbbe8b66bee36875715a1dcf035d33cR77-R78 -- I believe the min and max were purposely set to invalid values so that the provisioner would not be initialized.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants