Fix enforcing termsOfServiceAgreed in ACME server#2610
Open
JiwaniZakir wants to merge 1 commit intosmallstep:masterfrom
Open
Fix enforcing termsOfServiceAgreed in ACME server#2610JiwaniZakir wants to merge 1 commit intosmallstep:masterfrom
JiwaniZakir wants to merge 1 commit intosmallstep:masterfrom
Conversation
When a provisioner has termsOfService configured, reject new account creation if termsOfServiceAgreed is not true, per RFC 8555 §7.3.3. Fixes smallstep#2539
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2539
When an ACME provisioner has
termsOfServiceconfigured,NewAccountinacme/api/account.gowas creating accounts regardless of thetermsOfServiceAgreedfield in the request, violating RFC 8555 §7.3.3. Adds a check before account creation that returns anErrorUserActionRequiredTypeerror iftermsOfServiceAgreedis nottrue.