Skip to content

Fix enforcing termsOfServiceAgreed in ACME server#2610

Open
JiwaniZakir wants to merge 1 commit intosmallstep:masterfrom
JiwaniZakir:acme-server-does-not-2539
Open

Fix enforcing termsOfServiceAgreed in ACME server#2610
JiwaniZakir wants to merge 1 commit intosmallstep:masterfrom
JiwaniZakir:acme-server-does-not-2539

Conversation

@JiwaniZakir
Copy link
Copy Markdown

Fixes #2539

When an ACME provisioner has termsOfService configured, NewAccount in acme/api/account.go was creating accounts regardless of the termsOfServiceAgreed field in the request, violating RFC 8555 §7.3.3. Adds a check before account creation that returns an ErrorUserActionRequiredType error if termsOfServiceAgreed is not true.

When a provisioner has termsOfService configured, reject new account
creation if termsOfServiceAgreed is not true, per RFC 8555 §7.3.3.

Fixes smallstep#2539
@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Mar 19, 2026
@hslatman hslatman changed the title fix: : ACME server does not enforce termsOfServiceAgreed when termsOfSer Fix enforcing termsOfServiceAgreed in ACME server Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ACME server does not enforce termsOfServiceAgreed when termsOfService is configured

3 participants