Skip opening the default browser if STEP_OPEN_BROWSER=false #1361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
jdoss
changed the title
hslatman
reviewed
Feb 12, 2025
hslatman
reviewed
Feb 14, 2025
Comment on lines
787
to
790
| if skipBrowser := os.Getenv("STEP_OPEN_BROWSER") == "0"; skipBrowser { | ||
| fmt.Fprintln(os.Stderr, authURL) | ||
| fmt.Fprintln(os.Stderr) | ||
| } else { | ||
| fmt.Fprintln(os.Stderr, "Your default web browser has been opened to visit:") | ||
| fmt.Fprintln(os.Stderr) | ||
| fmt.Fprintln(os.Stderr, authURL) | ||
| fmt.Fprintln(os.Stderr) | ||
| } else { | ||
| if err := exec.OpenInBrowser(authURL, o.browser); err != nil { |
Member
There was a problem hiding this comment.
Looks like the file needs to be formatted.
The version of the linter to use in CI was updated recently. It needs a rerun with fresh commit to go green.
added 2 commits
February 25, 2025 10:38
hslatman
force-pushed
the
jdoss/skip_browser
branch
from
b80b7ef to
31c9b14
Compare
Member
|
@jdoss I've rebased your changes. |
dopey
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
STEP_OPEN_BROWSERenv var which if set toSTEP_OPEN_BROWSER=falseit will skip opening the default browser and just output the authURL to stderr.