Allow a few global defaults to be pulled from the CA #1377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
dopey
force-pushed
the
max/provisioner-password
branch
from
d8493f8 to
45286f9
Compare
- min-encryption-password-length - provisioner Enforce min-encryption-password-length, if set, in the 'step ssh certificate' command.
dopey
force-pushed
the
max/provisioner-password
branch
from
5de1ab3 to
9b1015f
Compare
maraino
reviewed
Mar 3, 2025
utils/cautils/bootstrap.go
Outdated
Comment on lines
31
to
32
| Issuer string `json:"issuer"` | ||
| MinPasswordLength int `json:"min-password-length"` |
Collaborator
There was a problem hiding this comment.
We probably want omitempty
Provisioner string `json:"provisioner,omitempty"`
RedirectURL should also have an omitempty
Collaborator
There was a problem hiding this comment.
This is the response, so it can be ok here.
maraino
reviewed
Mar 3, 2025
utils/cautils/bootstrap.go
Outdated
Comment on lines
92
to
94
| Redirect string `json:"redirect-url"` | ||
| Issuer string `json:"issuer,omitempty"` | ||
| MinPasswordLength int `json:"min-password-length,omitempty"` |
Collaborator
There was a problem hiding this comment.
Omit empty on redirect-url and Provisioner instead of issuer.
- FirstStringOf returns value of first defined flag in input list
maraino
reviewed
Mar 4, 2025
utils/cautils/token_flow.go
Outdated
|
|
||
| // Filter by issuer (provisioner name) | ||
| if issuer := ctx.String("issuer"); issuer != "" { | ||
| if issuer := flags.FirstStringOf(ctx, "issuer", "provisioner"); issuer != "" { |
Collaborator
There was a problem hiding this comment.
Here and above, I would preffer "provisioner", "issuer"
maraino
previously approved these changes
Mar 4, 2025
Collaborator
maraino
left a comment
maraino
left a comment
There was a problem hiding this comment.
lgtm, ideally the api should set provisioner too, but ...
maraino
reviewed
Mar 4, 2025
flags/flags_test.go
Outdated
Comment on lines
297
to
340
| /* | ||
| { | ||
| name: "negative", | ||
| minLength: -5, | ||
| promptRun: promptRunner([]string{"foobar"}, nil), | ||
| want: "foobar", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "zero", | ||
| minLength: 0, | ||
| promptRun: promptRunner([]string{"foobar"}, nil), | ||
| want: "foobar", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "greater-than-min-length", | ||
| minLength: 5, | ||
| promptRun: promptRunner([]string{"foobar"}, nil), | ||
| want: "foobar", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "equal-min-length", | ||
| minLength: 6, | ||
| promptRun: promptRunner([]string{"foobar"}, nil), | ||
| want: "foobar", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "less-than-min-length", | ||
| minLength: 8, | ||
| promptRun: promptRunner([]string{"pass", "foobar", "password"}, nil), | ||
| want: "password", | ||
| wantErr: false, | ||
| }, | ||
| { | ||
| name: "ignore-post-whitespace-characters", | ||
| minLength: 7, | ||
| promptRun: promptRunner([]string{"pass ", "foobar ", "password "}, nil), | ||
| want: "password", | ||
| wantErr: false, | ||
| }, | ||
| */ |
Collaborator
There was a problem hiding this comment.
Can you uncomment or remove these tests?
utils/cautils/bootstrap.go
Outdated
Comment on lines
31
to
32
| Provisioner string `json:"provisioner,omitempty"` | ||
| MinPasswordLength int `json:"min-password-length,omitempty"` |
Collaborator
There was a problem hiding this comment.
Ok, but on responses omitempty is not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce min-password-length, if set, in the 'step ssh certificate' command.