Make --attestation-uri incompatible with --kms #1516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ACME-DA flow in the step ca certificate command expects all KMS parameters to be provided through the `--attestation-uri` flag. Using the `--kms` flag at the same time can lead to errors. For example, if the YubiKey PIN is set with the `--kms` flag, the flow will ignore it and use the default one instead, resulting in a PIN retry error. Fixes #1492
github-actions
bot
added
the
needs triage
maraino
requested review from
dopey and
hslatman
and removed request for
dopey
hslatman
approved these changes
Nov 12, 2025
Member
There was a problem hiding this comment.
Change looks OK.
Is it possible the behavior changed at some point? I remember we've done some changes to KMS URI parsing and using the KMS plugin, and things like that. Carl's blog does show the pin-value being set through --kms: https://smallstep.com/blog/access-your-homelab-anywhere/#testing-it-out, so presumably it worked like that at some point, and is why #1492 happened.
Member
|
@tashian ☝️ |
Collaborator
Author
|
I haven't seen any use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ACME-DA flow in the step ca certificate command expects all KMS parameters to be provided through the
--attestation-uriflag. Using the--kmsflag at the same time can lead to errors. For example, if the YubiKey PIN is set with the--kmsflag, the flow will ignore it and use the default one instead, resulting in a PIN retry error.Fixes #1492