Add support for 256 bit AES key encryption #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RSA 3072, RSA 4096, ECDSA P384 and ECDSA P512 EKs use a different AES block size for credential activation.
hslatman
force-pushed
the
herman/rsa3072-aes256
branch
from
aa122c6 to
2c2b580
Compare
Member
Author
|
Towards: DVC-212. |
hslatman
changed the title
The `legacy/tpm2` package was using the length of the symmetric key as the length for the IV. This is wrong, as AES256 has a 32 byte key, but the block size is 16. By using `github.com/google/go-tpm@7d0adf0a5e3b`, we get the correct IV size. The change was approved already, but it's waiting to be merged.
Member
Author
|
Had to bump some CI config because of the |
hslatman
force-pushed
the
herman/rsa3072-aes256
branch
from
e549f4f to
d56b55d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RSA 3072, RSA 4096, ECDSA P384 and ECDSA P521 EKs use a different AES key size for credential activation.