fix(registries): versioned User-Agent for Pulse (410) + Fleur stdio not remote#568
Merged
Merged
Conversation
Two registry-parser bugs in internal/registries/search.go: - Pulse (#566): fetchServers sent no User-Agent; api.pulsemcp.com now 410s empty/bare UAs and only 200s a versioned one. Set a "mcpproxy/<version>" User-Agent (wired SetVersion from main, mirroring guesser.go). - Fleur (#567): constructServerURL synthesised an https endpoint for every Fleur app, making local stdio apps (InstallCmd set) show as "Remote" in the frontend — same class as Docker #483. Return "" when InstallCmd is set. Test-first: httptest 410s on empty/bare UA and asserts fetchServers sends a versioned UA; TestConstructServerURL gains a Fleur-with-InstallCmd case. Related #566 Related #567
Deploying mcpproxy-docs with
|
| Latest commit: |
1a10eb6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3cfffb1b.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-registry-pulse-ua-fleur.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26776712340 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two registry-parser bugs in
internal/registries/search.go. Both edit the same file, so they ship on one branch + one PR (per MCP-855).Bug A — Pulse 410 (#566)
fetchServers()sent noUser-Agent.api.pulsemcp.com/v0beta/serversnow410s requests with an empty or bare UA and only200s a versioned one (reproduced: empty→410,mcpproxy→410,mcpproxy/0.35.0→200).Fix: set
User-Agent: mcpproxy/<version>infetchServers(mirrorsinternal/experiments/guesser.go:285). Version is wired via a newregistries.SetVersion(version)call inmain.goalongside the existingcliclient.SetClientVersion/server.SetMCPServerVersion; defaults todev.Bug B — Fleur all-remote (#567)
constructServerURL()synthesisedhttps://api.fleurmcp.com/apps/<id>/mcpfor every Fleur app.parseFleurpopulatesInstallCmd(local stdio) and leavesURLempty, so the synthesised URL made the frontend register these stdio apps as Remote. Same class as the Docker #483 bug.Fix: for
protocolFleur, return""whenserver.InstallCmd != "". Fleur apps without an install command (true remote endpoints) still get the synthesised URL.Tests (test-first, both watched fail then pass)
TestFetchServers_SendsVersionedUserAgent— httptest server that410s on empty/bare UA (mirrors Pulse); assertsfetchServerssends a versioned UA and succeeds.TestConstructServerURL— newfleur protocol with InstallCmd returns empty (stdio not remote)case (mirrors the Error adding server from Docker repository #483 regression case).Verification
go build ./cmd/mcpproxy— okgo test ./internal/registries/... -race— ok./scripts/run-linter.sh— 0 issuesNo CLI/REST/MCP/config surface changed (internal registry parsing only), so no docs update is required.
Related #566
Related #567