ci(prerelease): fix v0.37.0-rc.1 build failure#586
Merged
Conversation
The prerelease Windows matrix entries used os: ubuntu-latest, but the
'Install Inno Setup' / 'Create Windows installer' steps require a real
Windows runner (Chocolatey + ISCC.exe). On Ubuntu, 'choco' does not
exist, so the v0.37.0-rc.1 prerelease build (run 26926147427) failed:
choco: The term 'choco' is not recognized as a name of a cmdlet...
##[error]Process completed with exit code 1.
Switch the two Windows matrix entries to windows-latest with cgo: "1",
matching the proven release.yml configuration. Because the shared build
steps now run on a Windows host (default shell pwsh), add shell: bash to
the bash-syntax steps ('Copy frontend dist', 'Build binary and create
archives') and use PowerShell Compress-Archive for the Windows .zip
(the 'zip' command is unavailable in Git-bash on windows-latest) — all
mirroring release.yml. macOS/Linux build behavior is unchanged.
Deploying mcpproxy-docs with
|
| Latest commit: |
8f4f924
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fb8f6a0f.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://worktree-agent-a700558d3e88a.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26929530587 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The first real RC build — tag
v0.37.0-rc.1→ prerelease.yml run 26926147427 — failed at the Install Inno Setup (Windows) step on both Windows matrix entries:The prerelease Windows matrix entries were configured with
os: ubuntu-latest(cross-compiling the Windows binary on Linux). But theInstall Inno SetupandCreate Windows installersteps require a real Windows runner — they callchoco install innosetupandISCC.exe, neither of which exists on Ubuntu. By contrast,release.ymlruns these same steps onos: windows-latest.This was a latent bug (not introduced by PR #582). It surfaced now because #582 de-conflicted the workflows so an RC tag runs prerelease.yml end-to-end for the first time, exercising the Windows-installer path on the Linux runner.
The task hypothesis about an Inno Setup
VersionInfoVersion4-part-numeric rejection of-rc.1does not apply:scripts/installer.issonly setsAppVersion={#Version}(accepts arbitrary strings), noVersionInfoVersion.Fix (
.github/workflows/prerelease.yml)Mirror the proven
release.ymlWindows configuration:os: windows-latest,cgo: "1"(wasubuntu-latest,cgo: "0") for both amd64 + arm64 — giveschoco/ISCC.exeand matches release.yml.shell: bashto the cross-platform bash steps (Copy frontend dist to embed location,Build binary and create archives) — GHA defaults topwshonwindows-latest, and these blocks use bash syntax ([[ ]],${VAR#prefix},rm -rf,cp -r). release.yml setsshell: bashfor the same reason..zipvia PowerShellCompress-Archive— thezipcommand is unavailable in Git-bash onwindows-latest; release.yml already does this with the same comment.macOS/Linux build behavior is unchanged (those matrix entries untouched; the Windows-only
ifbranch and the newshell: bashmatch what those steps already used).Validation
python -c 'import yaml; yaml.safe_load(open(...))'→ valid YAML.release.ymlWindows handling, which builds Windows installers successfully today.Re-testing the RC build (post-merge)
This PR does not re-tag or touch the release. After merge, either:
v0.37.0-rc.1tag to the new main commit and re-push, orv0.37.0-rc.2tag.Then confirm the prerelease.yml run is green (esp. both Windows
buildjobs) and a GitHub pre-release is published.Related: PR #582 (MCP-1012).