feat(macos): registry-info popup on badge click; drop configured-registries panel#589
Merged
Merged
Conversation
…stries panel In the macOS Registries/browse view: - Remove the bottom "Configured registries" description panel. The registry list now lives in the browse multiselect and the per-result badge popup. The Add-Registry affordance is kept; load errors surface via an inline banner instead of the removed panel. - Make the per-result registry badge tappable. Clicking it opens a sheet showing the registry's name, provenance badge, description and URL, looked up from the loaded registries by id then name (case-insensitive). Falls back to the raw label when nothing matches; custom/unverified registries show the always-quarantined note. Adds Registry.lookup(_:in:) with unit tests. Related: MCP-1050
Deploying mcpproxy-docs with
|
| Latest commit: |
efa1cde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5a707cf5.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://mcp-1050-macos-registry-popu.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26938411729 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why (MCP-1050, v0.37.0 blocker)
macOS Registries/browse view polish:
(a) Removed the bottom "Configured registries" description panel. The registry list is already reachable via the browse multiselect and now via the per-result badge popup, so the redundant bottom panel is gone. The Add-Registry affordance is kept; registry-load errors now surface via an inline banner (the panel previously owned that error state).
(b) Made the per-result registry badge tappable → info popup. Clicking the
<registry> ⓘbadge on a search-result card opens a sheet showing the registry's name, provenance badge (reuses the official/custom styling), description, and URL. The fullRegistryis looked up from the loaded list by id, then by name (case-insensitive) — search results carry the registry name, while the add endpoint uses the id, so both are handled. Custom/unverified registries show the always-quarantined note; an unmatched label degrades gracefully to a name-only popup.Files
API/RegistryModels.swift—Registry.lookup(_:in:)(id-then-name, case-insensitive).Views/RegistriesView.swift— drop the bottom panel + deadcontent/registryRow/badge helpers; inline load-error banner.Views/ServerBrowseView.swift— tappable badgeButton,RegistryInfoContext,.sheet(item:)info popup + provenance/badge helpers.MCPProxyTests/RegistryModelsTests.swift— 4 lookup tests (TDD: red → green).Verification
swift build— clean (only pre-existing resource warnings).swift test --filter RegistryModelsTests— 17/17 green (incl. 4 new). The 7 failures in the full suite (AutoStart/MergePatch/SSE) are pre-existing onorigin/mainand unrelated; macOS CI builds the app and does not runswift test.Reference Servers ⓘbadge → info popup opened showing name +Official · trustedbadge + description +builtin://referenceURL.Related: MCP-1050