fix(serveredition): move orphaned broker connector into serveredition pkg (MCP-2455)#679
Merged
Merged
Conversation
… pkg (MCP-2455) PR #602 added internal/teams/broker/oauth_connector.go AFTER the Teams->Server Edition rename (#603) moved internal/teams/ -> internal/serveredition/. The connector landed in the stale path, in package broker, referencing CredentialStore/UpstreamCredential as same-package symbols — but those live in internal/serveredition/broker. Result: 'undefined: CredentialStore' under -tags server, breaking the Server Edition CI job on main (and therefore on every open PR after #631 added that job to PR CI). Fix: git mv the connector + its test into internal/serveredition/broker/ (no importers of the old path) and delete the now-empty internal/teams/ tree. Same package, so all refs resolve. No code changes. Verified: go build -tags server ./... (0), go build ./... (0), go test -tags server ./internal/serveredition/... (all ok). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![mcpproxy-gatekeeper[bot]](https://avatars.githubusercontent.com/u/216428285?s=60&v=4){kind=small}
Deploying mcpproxy-docs with
|
| Latest commit: |
1115f7c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64373a91.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-mcp-2455-broker-connecto.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Dumbris
added a commit
that referenced
this pull request
Jun 15, 2026
… deleted internal/teams) (#680) The Server Edition CI job (added #631) ran: go test -race -tags server ./internal/teams/... ./internal/config/... But the Teams->Server Edition rename (#603) moved that code to internal/serveredition/, and #679 deleted the last stale internal/teams/ file. So the job failed with 'lstat ./internal/teams/: no such file or directory' — and before that, it was silently testing the wrong (stale, near-empty) path, never the real serveredition packages. Fix: test ./internal/serveredition/... instead. Verified locally: go test -race -tags server ./internal/serveredition/... ./internal/config/... -> all 8 packages ok. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Server Edition CI (
-tags server) is red on main, which fails theServer Editioncheck on every open PR (#677, #675, #674, #673, #672, #649) since #631 added that job to PR CI.Root cause: PR #602 added
internal/teams/broker/oauth_connector.goafter the Teams→Server Edition rename (#603) movedinternal/teams/→internal/serveredition/. The connector landed in the stale path aspackage broker, referencingCredentialStore/UpstreamCredentialas same-package symbols — but those live ininternal/serveredition/broker. Result:Fix
git mvthe connector + its test intointernal/serveredition/broker/(no importers of the old path) and delete the now-emptyinternal/teams/tree. Same package → all refs resolve. No code changes.Verification
go build -tags server ./...→ exit 0go build ./...(personal edition) → exit 0go test -tags server ./internal/serveredition/...→ all packages ok (incl. broker connector tests)Unblocks the 6 PRs above once they rebase. Fixes MCP-2455.
🤖 Generated with Claude Code