Skip to content

Conversation

ecPablo
Copy link
Contributor

@ecPablo ecPablo commented Oct 17, 2025

This pull request refactors the update logic in the bump-mcms-tools GitHub Action to improve maintainability and clarity. The main change is moving the workflow file update logic from an inline shell script in action.yml to a separate script file. Additionally, the installation of yq is no longer handled within the action itself.

Refactoring and maintainability:

  • Extracted the workflow update logic from an inline shell script in action.yml to a dedicated script file at scripts/update-workflow-files.sh, making the codebase cleaner and easier to maintain. [1] [2]

Dependency management:

  • Removed the explicit installation step for yq from the action workflow, assuming it is now managed elsewhere or provided by the environment.

@ecPablo ecPablo marked this pull request as ready for review October 17, 2025 14:30
@ecPablo ecPablo requested a review from a team as a code owner October 17, 2025 14:30
@ecPablo ecPablo marked this pull request as draft October 17, 2025 14:32
ecPablo and others added 2 commits October 17, 2025 08:37
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@ecPablo ecPablo marked this pull request as ready for review October 17, 2025 15:11
Copy link
Collaborator

@chainchad chainchad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need the shebang and then LGTM

@ecPablo ecPablo merged commit 831d704 into main Oct 17, 2025
19 checks passed
@ecPablo ecPablo deleted the ecpablo/mcms-tools-bump-fixes branch October 17, 2025 15:20
@ecPablo ecPablo changed the title fix: remove yq install step and move sh script to separate file fix: remove yq install step and move sh script to separate file [DX-2072] Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants