-
Notifications
You must be signed in to change notification settings - Fork 2
[TT-1693] reusable solidity artifacts workflow #608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-1693] reusable solidity artifacts workflow #608
Conversation
ed461ed
to
f2887cf
Compare
99c452e
to
4ffaa92
Compare
4ffaa92
to
058dd78
Compare
88ccb7b
to
09b882e
Compare
5dea933
to
04fa279
Compare
04fa279
to
9c0d065
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, just posted one question.
It's pretty complex setup, would be nice if you can add a CODEOWNER entry for all the files added in this PR, so we can easily tag the right people to review changes in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tofel Have you considered packaging this as a Typescript based action instead of a lib?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not, because I have copied that code from chainlink
repo. It was originally created by @momentmaker and @HenryNguyen5 and I didn't want to modify more things than strictly necessary.
This PR introduces a reusable Solidity Review Artifact generating pipeline that currently was stored in
chainlink
repository.I have made it more universal, so that it's possible to use with repositories that use different project structure (
chainlink
repo is very specific in that regard).I have tested it with typical Foundry layout and it works like a charm. Here's a working example: https://github.com/smartcontractkit/solidity-review-artifacts-example that also describes how to use this pipeline in any repository.
Apart from the workflow itself I had to move a couple of scripts and actions:
You can find some sample executions here: https://github.com/smartcontractkit/solidity-review-artifacts-example/actions/workflows/solidity-review-artifacts.yml