-
Notifications
You must be signed in to change notification settings - Fork 22
Add separate Ethers adapter demo page #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 thodges-gh, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a small commit on top - adjust README for demo app and also minor nit changes to UI widgets.
Also left some small comments for you to consider. I also saw some copilot / CI /CD generated comments on mixed exports of components and functions not working in hot refreshes etc. Consider whether those need adjustment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: add a single write operation to the /ccip-ethers
route to ensure writes work via UI
Please note the "Unchanged files with check annotations " on this files changed tab.
Other than that LGTM - wont be checking too deeply again given the reviews done previously.
Introduces a dedicated Next.js page that demonstrates using the Ethers adapter to create Viem clients from an ethers provider/signer, without modifying the existing Wagmi-based example.