Skip to content

Conversation

thodges-gh
Copy link
Contributor

Introduces a dedicated Next.js page that demonstrates using the Ethers adapter to create Viem clients from an ethers provider/signer, without modifying the existing Wagmi-based example.

Copy link

github-actions bot commented Oct 6, 2025

👋 thodges-gh, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copy link
Contributor

@zeuslawyer zeuslawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a small commit on top - adjust README for demo app and also minor nit changes to UI widgets.

Also left some small comments for you to consider. I also saw some copilot / CI /CD generated comments on mixed exports of components and functions not working in hot refreshes etc. Consider whether those need adjustment.

@thodges-gh thodges-gh requested a review from zeuslawyer October 8, 2025 16:32
Copy link
Contributor

@zeuslawyer zeuslawyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: add a single write operation to the /ccip-ethers route to ensure writes work via UI

Please note the "Unchanged files with check annotations " on this files changed tab.

Other than that LGTM - wont be checking too deeply again given the reviews done previously.

@thodges-gh thodges-gh merged commit 5158a95 into main Oct 13, 2025
10 checks passed
@thodges-gh thodges-gh deleted the chore/ethers-nextjs-page branch October 13, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants