-
Notifications
You must be signed in to change notification settings - Fork 77
Add CCT instructions to README #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds instructions for using the Cross-Chain Token (CCT) standard to the README, guiding users through environment setup and test commands.
- Added a new “CCT Standard” section to the Table of Contents and detailed instructions.
- Introduced
BASE_SEPOLIA_RPC_URL
environment variable in prerequisites. - Provided CCT overview, example file references, and test commands.
Comments suppressed due to low confidence (1)
README.md:725
- The filename in the square brackets (
CCIPv1_5ForkBurnMintPoolFork.t.sol
) does not match the linked file path (CCIPv1_5BurnMintPoolFork.t.sol
). Please correct the reference so both match the actual test file name.
1. `getCCIPAdmin()` function in `MockERC20BurnAndMintToken` in [`CCIPv1_5ForkBurnMintPoolFork.t.sol`](./test/fork/CCIPv1_5BurnMintPoolFork.t.sol) file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! left some comments and then good to merge!
To run CCT examples make sure you have the following environment variables set in your `.env` file: | ||
|
||
```shell | ||
ETHEREUM_SEPOLIA_RPC_URL="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a way to do this without adding another config env var for BASE? each additional var adds friction to the end user in terms of steps etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapped Base Sepolia for Avalanche Fuji
This PR adds CCT instructions to README file