deployment: Set OCR3 config #1233
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archseer
commented
Oct 3, 2025
| ConfigDigest: configForOCR3.ConfigDigest, | ||
| OcrPluginType: uint8(pluginType), | ||
| F: configForOCR3.Config.FRoleDON, | ||
| IsSignatureVerificationEnabled: pluginType == ccipocr3.PluginTypeCCIPCommit, |
There was a problem hiding this comment.
ccipocr3.PluginType was recently added by @ogtownsend to common, we should use them everywhere in core as well and retire the old types
archseer
commented
Oct 3, 2025
| CapabilityVersion = "v1.0.0" | ||
| ) | ||
|
|
||
| var CCIPCapabilityID = hashutil.NewKeccak().Hash(mustABIEncode(`[{"type": "string"}, {"type": "string"}]`, CapabilityLabelledName, CapabilityVersion)) |
There was a problem hiding this comment.
We need to do something like this in core too, a lot of unnecessary "github.com/smartcontractkit/chainlink-evm/pkg/utils" imports
archseer
commented
Oct 3, 2025
Comment on lines
+43
to
+44
| state.Chains[homeChainSelector].CapabilityRegistry, | ||
| state.Chains[homeChainSelector].CCIPHome, |
There was a problem hiding this comment.
What should we do here? Need to avoid the stateview dep?
There was a problem hiding this comment.
something like this I think
homeFamily, err := chain_selectors.GetSelectorFamily(homeChainSelector)
if err != nil {
return nil, err
}
ccipHome, err := registeredChainAdapters[homeFamily].GetCCIPHome(e, homeChainSelector)
if err != nil {
return nil, err
}
capabilityRegistry, err := registeredChainAdapters[homeFamily].GetCapabilityRegistry(e, homeChainSelector)
if err != nil {
return nil, err
}
donID, err := internal.DonIDForChain(
ccipHome,
capabilityRegistry,
chainSelector,
)
if err != nil {
return nil, fmt.Errorf("failed to get DON ID: %w", err)
}
archseer
commented
Oct 3, 2025
| github.com/smartcontractkit/chainlink-ccip v0.1.1-solana.0.20250911201806-5a095deaeb52 | ||
| github.com/smartcontractkit/chainlink-common v0.9.6-0.20250930212138-0b782340a7f5 | ||
| github.com/smartcontractkit/chainlink-deployments-framework v0.44.0 | ||
| github.com/smartcontractkit/chainlink-evm/gethwrappers v0.0.0-20250827130336-5922343458be |
There was a problem hiding this comment.
I made sure we depend on gethwrappers only, chainlink-evm/pkg should be an auto-deny lint
There was a problem hiding this comment.
Yeah let's set up a linter for this separately.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.