Add billing params to ccv & call in ramp #1295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RensR
commented
Oct 17, 2025
| Receipt[] verifierReceipts, | ||
| Receipt executorReceipt, | ||
| bytes[] receiptBlobs | ||
| Receipt[] receipts, |
There was a problem hiding this comment.
All receipts are now part of this single list
RensR
commented
Oct 17, 2025
| bytes[] verifierBlobs | ||
| ); | ||
|
|
||
| struct CCIPMessageSentEventData { |
There was a problem hiding this comment.
This was introduced to resolve the stack-too-deep and feels cleaner than re-stating variables.
RensR
commented
Oct 17, 2025
|
|
||
| // Change chain ID to simulate fork. | ||
| uint256 originalChainId = block.chainid; | ||
| uint256 originalChainId = uint128(block.chainid); |
There was a problem hiding this comment.
This is to make running tests with via-ir work
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCVs are allowed to charge fees in dollars. Currently, these fees are not converted, this will be done in a future PR.
in scope of this PR
_evmMessageToEventaccuracy: it fully resolves CCV feesThis PR removes the onRamp and the committeeVerifier from the coverage pruning, meaning they must always remain >98% cov now.